What's the best way to submit patches?

Any community contributions to libgdx go here! Some may get included in the core API when permission is granted.

What's the best way to submit patches?

Postby viridia » Sat Apr 07, 2012 7:57 pm

I'd like to offer some minor additions to SpriteBatch and a few other classes. What's the best way to submit a patch?
-- Talin
viridia
 
Posts: 66
Joined: Wed Mar 07, 2012 12:43 am

Re: What's the best way to submit patches?

Postby BurningHand » Sat Apr 07, 2012 8:17 pm

Probably be best to attach the patch file to the issue tracker.
IRC: nexsoftware / mobidevelop; GitHub: MobiDevelop;
BurningHand
 
Posts: 2429
Joined: Mon Oct 25, 2010 4:35 am

Re: What's the best way to submit patches?

Postby mzechner » Sat Apr 07, 2012 8:39 pm

Problem is that Google Code has a 50mb attachment limit for the issue tracker, and we reached that :/ If you could host your diff somewhere and just link to it it would be the best option. I usually do not accept pull requests on Github as that repo is not fully functional. We can't link in the external modules for gdx/ (table-layout) with git.
mzechner
Site Admin
 
Posts: 4715
Joined: Sat Jul 10, 2010 3:50 pm

Re: What's the best way to submit patches?

Postby BurningHand » Sat Apr 07, 2012 11:09 pm

Eww, that's not a lot of space now is it?
IRC: nexsoftware / mobidevelop; GitHub: MobiDevelop;
BurningHand
 
Posts: 2429
Joined: Mon Oct 25, 2010 4:35 am

Re: What's the best way to submit patches?

Postby viridia » Sun Apr 08, 2012 2:29 am

I'll try and remember to ask the Google Code folks about this when I get back to work on Monday, see if there is some workaround. (Yeah. my day job is working on Google+.)
-- Talin
viridia
 
Posts: 66
Joined: Wed Mar 07, 2012 12:43 am

Re: What's the best way to submit patches?

Postby mzechner » Sun Apr 08, 2012 10:08 am

That would be fantastic!
mzechner
Site Admin
 
Posts: 4715
Joined: Sat Jul 10, 2010 3:50 pm

Re: What's the best way to submit patches?

Postby viridia » Mon Apr 09, 2012 10:53 pm

OK it's been increased to 512 MB.

Here's what he said:

Feel free to contact us if they run out again. They can also contact us on google-code-hosting@googlegroups.com, we always honor these requests for legitimate users.
-- Talin
viridia
 
Posts: 66
Joined: Wed Mar 07, 2012 12:43 am

Re: What's the best way to submit patches?

Postby mzechner » Tue Apr 10, 2012 11:04 am

Wow, awesome, thanks a bunch!
mzechner
Site Admin
 
Posts: 4715
Joined: Sat Jul 10, 2010 3:50 pm

Re: What's the best way to submit patches?

Postby viridia » Wed Apr 11, 2012 2:16 am

Anyway, I presume this means I can go ahead and submit patches via the bug tracker? :) Does each patch need to have a license statement, or is there a blanket contributor agreement that I can simply agree to in advance?
-- Talin
viridia
 
Posts: 66
Joined: Wed Mar 07, 2012 12:43 am

Re: What's the best way to submit patches?

Postby mzechner » Wed Apr 11, 2012 8:35 am

For simple bug fixes consisting of a few lines we usually don't require signing the CLA. In all other cases we need a signed copy of this http://libgdx.googlecode.com/svn/trunk/CLA.txt
mzechner
Site Admin
 
Posts: 4715
Joined: Sat Jul 10, 2010 3:50 pm


Return to Libgdx Contributions

Who is online

Users browsing this forum: No registered users and 0 guests