OpenGL ES 3.1 Support (LWJGL3 + Android)

Any community contributions to libgdx go here! Some may get included in the core API when permission is granted.

OpenGL ES 3.1 Support (LWJGL3 + Android)

Postby spamrakuen » Fri Feb 24, 2017 5:51 pm

Hi there,

Some time ago I've added some missing OpenGL ES 3.0 functions to LibGdx.
I've been asked to do a Pull Request of my changes but first I wanted to finish my project to be sure that I do not need more missing GL ES 3.0 functions.
Finally, my project is working (thanks to SSBOs and compute shaders), and I've also added support for OpenGL ES 3.1 to LWJGL3 and Android backends.

My changes are based on LibGdx v1.9.3.
Since I'm a total noob with git, can anybody explain me how can I do a pull request for that version?

Thanks.
spamrakuen
 
Posts: 21
Joined: Wed Jun 25, 2014 2:01 pm

Re: OpenGL ES 3.1 Support (LWJGL3 + Android)

Postby evilentity » Fri Feb 24, 2017 6:22 pm

You dont. You need to update to latest first.
Looking for a freelancer? PM me!
evilentity
 
Posts: 4250
Joined: Wed Aug 24, 2011 11:37 am

Re: OpenGL ES 3.1 Support (LWJGL3 + Android)

Postby wiverson » Fri Feb 24, 2017 9:55 pm

https://help.github.com/articles/about-pull-requests/ (also lots of other articles if you search for GitHub pull request)

Basically, check out a close of libGDX, create a branch, make changes, and then submit a pull request. You can create two free accounts on GitHub and play around with it to learn more.

You will also need to review the libGDX wiki for changes: https://github.com/libgdx/libgdx/wiki/Contributing
wiverson
 
Posts: 9
Joined: Fri Oct 07, 2016 10:12 pm

Re: OpenGL ES 3.1 Support (LWJGL3 + Android)

Postby spamrakuen » Tue Feb 28, 2017 6:01 pm

Hi,

I've created a new brach with

Code: Select all
git checkout -b gles31


modified the files, added some files with "git add", then I've used

Code: Select all
git checkout gles31


and finally

Code: Select all
git push -u https://github.com/libgdx/libgdx.git gles31


But I've got a 403 error (permission denied)

What I'm doing wrong?

Thanks, and sorry to bother you with this.
spamrakuen
 
Posts: 21
Joined: Wed Jun 25, 2014 2:01 pm

Re: OpenGL ES 3.1 Support (LWJGL3 + Android)

Postby evilentity » Tue Feb 28, 2017 8:05 pm

Yeah, you cant do that.
You fork the libgdx repo, you make changes to that forked repo and then you go to https://github.com/libgdx/libgdx and click make pull request button.
Looking for a freelancer? PM me!
evilentity
 
Posts: 4250
Joined: Wed Aug 24, 2011 11:37 am

Re: OpenGL ES 3.1 Support (LWJGL3 + Android)

Postby spamrakuen » Wed Mar 01, 2017 10:56 pm

evilentity wrote:Yeah, you cant do that.
You fork the libgdx repo, you make changes to that forked repo and then you go to https://github.com/libgdx/libgdx and click make pull request button.


Thank you. It wasn't easy,
Pull request done, I hope all will be right.
spamrakuen
 
Posts: 21
Joined: Wed Jun 25, 2014 2:01 pm

Re: OpenGL ES 3.1 Support (LWJGL3 + Android)

Postby Leejjon » Fri Mar 03, 2017 10:57 pm

The automatic tests failed:
https://github.com/libgdx/libgdx/pull/4628

They have a Jenkins machine running that tried to build libgdx with your changes, look at the bottom for the error:
http://144.76.220.132:8080/job/libgdx-p ... 16/console

Did you try to do a full maven build with your changes on your local machine before making that pull request?

And also, did you update to the latest libgdx version, that means the latest master branch?
http://leejjon.net

My Bluff Poker app made with libgdx (MOE for iOS):
- On Play Store: https://play.google.com/store/apps/deta ... er.android
- On Apple App Store: https://itunes.apple.com/app/id1299542538
Leejjon
 
Posts: 105
Joined: Mon Jan 14, 2013 9:55 pm

Re: OpenGL ES 3.1 Support (LWJGL3 + Android)

Postby spamrakuen » Mon Mar 06, 2017 1:45 pm

Leejjon wrote:The automatic tests failed:
https://github.com/libgdx/libgdx/pull/4628

They have a Jenkins machine running that tried to build libgdx with your changes, look at the bottom for the error:
http://144.76.220.132:8080/job/libgdx-p ... 16/console

Did you try to do a full maven build with your changes on your local machine before making that pull request?

And also, did you update to the latest libgdx version, that means the latest master branch?


Hi Leejjon,

Thak you for the feedback.

The libgdx version I've used for this pull request is the last one, and yes, I've compiled the source files with the "ant" command without troubles, but I may have used the 1.6 version of the JDK, that should be the reason why it does not compile.

Can anyone help me with this?
spamrakuen
 
Posts: 21
Joined: Wed Jun 25, 2014 2:01 pm

Re: OpenGL ES 3.1 Support (LWJGL3 + Android)

Postby AngelusWeb » Sun Jun 04, 2017 10:05 pm

Is LWJGL3 stable enough for production games at this point?

Also, is there another LibGDX release on the horizon? It's been about 3 months.

Just looking to update some of my games.

Matthew
AngelusWeb
 
Posts: 402
Joined: Fri Jul 20, 2012 8:19 pm

Re: OpenGL ES 3.1 Support (LWJGL3 + Android)

Postby spamrakuen » Thu Mar 22, 2018 5:23 pm

One year later and my pull request is still pending. Why? God, whyyy?

I'm enjoying very much OpenGL ES 3.1's Compute Shaders... they're very powerful.

Yeees, yeeeeeees... I know... I know... threre are still too few users with OpenGL ES 3.1 capable devices...
spamrakuen
 
Posts: 21
Joined: Wed Jun 25, 2014 2:01 pm


Return to Libgdx Contributions

Who is online

Users browsing this forum: No registered users and 1 guest